Anson Huang Best Regards!
> -----Original Message----- > From: Rob Herring [mailto:r...@kernel.org] > Sent: Friday, March 2, 2018 5:23 AM > To: Anson Huang <anson.hu...@nxp.com> > Cc: Leonard Crestez <leonard.cres...@nxp.com>; rui.zh...@intel.com; > edubez...@gmail.com; mark.rutl...@arm.com; shawn...@kernel.org; > ker...@pengutronix.de; Fabio Estevam <fabio.este...@nxp.com>; > li...@armlinux.org.uk; linux-arm-ker...@lists.infradead.org; > devicet...@vger.kernel.org; dl-linux-imx <linux-...@nxp.com>; > linux-kernel@vger.kernel.org; linux...@vger.kernel.org > Subject: Re: [PATCH V5 2/2] thermal: imx: add i.MX7 thermal sensor support > > On Thu, Mar 01, 2018 at 07:09:40AM +0800, Anson Huang wrote: > > This patch adds i.MX7 thermal sensor support, most of the i.MX7 > > thermal sensor functions are same with > > i.MX6 except the registers offset/layout, so we move those registers > > offset/layout definitions to soc data structure. > > > > i.MX7 uses single calibration data @25C, the calibration data is > > located at OCOTP offset 0x4F0, bit[17:9], the formula is as below: > > > > Tmeas = (Nmeas - n1) + 25; n1 is the fuse value for 25C. > > > > Signed-off-by: Anson Huang <anson.hu...@nxp.com> > > Signed-off-by: Bai Ping <ping....@nxp.com> > > Acked-by: Dong Aisheng <aisheng.d...@nxp.com> > > Acked-by: Shawn Guo <shawn...@kernel.org> > > --- > > changes since V4: > > drop direct OCOTP register access for i.mx7d since it is a new added > platform, > > only support reading ocotp values through the ocotp nvmem driver which > handles clock. > > .../devicetree/bindings/thermal/imx-thermal.txt | 9 +- > > drivers/thermal/imx_thermal.c | 295 > ++++++++++++++++----- > > 2 files changed, 239 insertions(+), 65 deletions(-) > > Please add ack/reviewed-by's when posting new versions. > > Rob Sorry for missing it, I just sent out a V6 adding Reviewed-by, thanks. Anson.