On Sun, Mar 4, 2018 at 2:56 PM, kbuild test robot <[email protected]> wrote: > From: Fengguang Wu <[email protected]> > > drivers/nvmem/meson-efuse.c:64:1-3: WARNING: PTR_ERR_OR_ZERO can be used > > > Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR > > Generated by: scripts/coccinelle/api/ptr_ret.cocci > > Fixes: 0d4f662ed6ff ("nvmem: meson-efuse: Do no gate COMPILE_TEST with > MESON_SM")
Original code was fine. This is more of a style preference, so I don't think it deserves a Fixes tag. > CC: Andrey Smirnov <[email protected]> > Signed-off-by: Fengguang Wu <[email protected]> > --- > > meson-efuse.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > --- a/drivers/nvmem/meson-efuse.c > +++ b/drivers/nvmem/meson-efuse.c > @@ -61,10 +61,7 @@ static int meson_efuse_probe(struct plat > econfig.size = size; > > nvmem = devm_nvmem_register(&pdev->dev, &econfig); > - if (IS_ERR(nvmem)) > - return PTR_ERR(nvmem); > - > - return 0; > + return PTR_ERR_OR_ZERO(nvmem); > } > > static struct platform_driver meson_efuse_driver = { > _______________________________________________ > kbuild-all mailing list > [email protected] > https://lists.01.org/mailman/listinfo/kbuild-all
