On 03/05/2018 12:42 PM, Khalid Aziz wrote:
> On 03/05/2018 12:24 PM, Dave Hansen wrote:
>> On 02/21/2018 09:15 AM, Khalid Aziz wrote:
>>> +#ifndef __HAVE_ARCH_COPY_HIGHPAGE
>>> +
>>> static inline void copy_highpage(struct page *to, struct page *from)
>>> {
>>> char *vfrom, *vto;
>>> @@ -248,4 +250,6 @@ static inline void copy_highpage(struct page *to,
>>> struct page *from)
>>> kunmap_atomic(vfrom);
>>> }
>>> +#endif
>>
>> I think we prefer that these are CONFIG_* options.
>
> I added this mechanism to be same as what we have for copy_user_highpage():
>
> ---------------
> #ifndef __HAVE_ARCH_COPY_USER_HIGHPAGE
I think that's the old way that we generally don't want to add new
instances of.
