On 3/5/2018 9:08 PM, Logan Gunthorpe wrote: > Clean up the extra ifdefs which defined the wr_reg64 and rd_reg64 > functions in non-64bit cases in favour of the new common > io-64-nonatomic-lo-hi header. > > To be consistent with CAAM engine HW spec: in case of 64-bit registers, > irrespective of device endianness, the lower address should be read from > / written to first, followed by the upper address. Indeed the I/O > accessors in CAAM driver currently don't follow the spec, however this > is a good opportunity to fix the code. > > Signed-off-by: Logan Gunthorpe <log...@deltatee.com> > Cc: Andy Shevchenko <andy.shevche...@gmail.com> > Cc: Horia Geantă <horia.gea...@nxp.com> > Cc: Dan Douglass <dan.dougl...@nxp.com> > Cc: Herbert Xu <herb...@gondor.apana.org.au> > Cc: "David S. Miller" <da...@davemloft.net> Reviewed-by: Horia Geantă <horia.gea...@nxp.com>
Please get used to carrying Reviewed-bys from previous iterations when patches stay the same: https://lkml.kernel.org/r/vi1pr0402mb334282217bc0ae1f8da8bfc398...@vi1pr0402mb3342.eurprd04.prod.outlook.com Thanks, Horia