Hi Rob,

On Thu, Mar 01, 2018 at 04:15:43PM -0600, Rob Herring wrote:
> On Wed, Feb 21, 2018 at 10:20:28AM +0100, Maxime Ripard wrote:
> > From: Maxime Ripard <maxime.rip...@free-electrons.com>
> > 
> > The Allwinner SoCs usually come with a DSI encoder. Add a binding for it.
> > 
> > Signed-off-by: Maxime Ripard <maxime.rip...@free-electrons.com>
> > ---
> >  Documentation/devicetree/bindings/display/sunxi/sun6i-dsi.txt | 84 +++++++-
> >  1 file changed, 84 insertions(+)
> >  create mode 100644 
> > Documentation/devicetree/bindings/display/sunxi/sun6i-dsi.txt
> > 
> > diff --git a/Documentation/devicetree/bindings/display/sunxi/sun6i-dsi.txt 
> > b/Documentation/devicetree/bindings/display/sunxi/sun6i-dsi.txt
> > new file mode 100644
> > index 000000000000..cbcc673b9bcc
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/display/sunxi/sun6i-dsi.txt
> > @@ -0,0 +1,84 @@
> > +Allwinner A31 DSI Encoder
> > +=========================
> > +
> > +The DSI pipeline consists of two separate blocks: the DSI controller
> > +itself, and its associated D-PHY.
> > +
> > +DSI Encoder
> > +-----------
> > +
> > +The DSI Encoder generates the DSI signal from the TCON's.
> > +
> > +Required properties:
> > +  - compatible: value must be one of:
> > +    * allwinner,sun6i-a31-mipi-dsi
> > +  - reg: base address and size of memory-mapped region
> > +  - interrupts: interrupt associated to this IP
> > +  - clocks: phandles to the clocks feeding the DSI encoder
> > +    * bus: the DSI interface clock
> > +    * mod: the DSI module clock
> > +  - clock-names: the clock names mentioned above
> > +  - phys: phandle to the D-PHY
> > +  - phy-names: must be "dphy"
> > +  - resets: phandle to the reset controller driving the encoder
> > +
> > +  - ports: A ports node with endpoint definitions as defined in
> > +    Documentation/devicetree/bindings/media/video-interfaces.txt. The
> > +    port should be the input endpoint, usually coming from the
> > +    associated TCON.
> > +
> > +Any MIPI-DSI device attached to this should be described according to
> > +the bindings defined in ../mipi-dsi-bus.txt
> > +
> > +D-PHY
> > +-----
> > +
> > +Required properties:
> > +  - compatible: value must be one of:
> > +    * allwinner,sun6i-a31-mipi-dphy
> > +  - reg: base address and size of memory-mapped region
> > +  - clocks: phandles to the clocks feeding the DSI encoder
> > +    * bus: the DSI interface clock
> > +    * mod: the DSI module clock
> > +  - clock-names: the clock names mentioned above
> > +  - resets: phandle to the reset controller driving the encoder
> > +
> > +Example:
> > +
> > +dsi0: dsi@1ca0000 {
> > +   compatible = "allwinner,sun6i-a31-mipi-dsi";
> > +   reg = <0x01ca0000 0x1000>;
> > +   interrupts = <GIC_SPI 89 IRQ_TYPE_LEVEL_HIGH>;
> > +   clocks = <&ccu CLK_BUS_MIPI_DSI>,
> > +            <&ccu CLK_DSI_SCLK>;
> > +   clock-names = "bus", "mod";
> > +   resets = <&ccu RST_BUS_MIPI_DSI>;
> > +   phys = <&dphy0>;
> > +   phy-names = "dphy";
> > +   #address-cells = <1>;
> > +   #size-cells = <0>;
> > +
> > +   panel@0 {
> > +           compatible = "huarui,lhr050h41";
> > +           reg = <0>;
> > +           power-gpios = <&pio 1 7 GPIO_ACTIVE_HIGH>; /* PB07 */
> > +           reset-gpios = <&r_pio 0 5 GPIO_ACTIVE_LOW>; /* PL05 */
> > +           backlight = <&pwm_bl>;
> > +   };
> > +
> > +   port {
> > +           dsi0_in_tcon0: endpoint {
> > +                   remote-endpoint = <&tcon0_out_dsi0>;
> > +           };
> > +   };
> 
> Kind of odd to have a mixture of panel and port. I guess that's valid 
> though.

I guess the most elegant way would have been to have the panel also
part of the OF graph, but we have to conform to the generic DSI panels
as well :)

> I'd recommend you put port under ports node so if you ever have 
> another port you are not mixing unit-address spaces.

Ok, I'll do that.

> With that,
> 
> Reviewed-by: Rob Herring <r...@kernel.org>

Thanks!
Maxime

-- 
Maxime Ripard, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com

Attachment: signature.asc
Description: PGP signature

Reply via email to