Hi Colin, On Tue, Mar 06, 2018 at 04:25:17PM +0100, Colin King wrote: > From: Colin Ian King <colin.k...@canonical.com> > > The function mvpp2_check_hw_buf_num is local to the source and does > not need to be in global scope, so make it static. > > Cleans up sparse warning: > drivers/net/ethernet/marvell/mvpp2.c:4298:5: warning: symbol > 'mvpp2_check_hw_buf_num' was not declared. Should it be static? > > Signed-off-by: Colin Ian King <colin.k...@canonical.com>
Acked-by: Antoine Tenart <antoine.ten...@bootlin.com> Thanks! Antoine > --- > drivers/net/ethernet/marvell/mvpp2.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/marvell/mvpp2.c > b/drivers/net/ethernet/marvell/mvpp2.c > index ac0a0dc8f157..61c6896d0d62 100644 > --- a/drivers/net/ethernet/marvell/mvpp2.c > +++ b/drivers/net/ethernet/marvell/mvpp2.c > @@ -4295,7 +4295,8 @@ static void mvpp2_bm_bufs_free(struct device *dev, > struct mvpp2 *priv, > } > > /* Check number of buffers in BM pool */ > -int mvpp2_check_hw_buf_num(struct mvpp2 *priv, struct mvpp2_bm_pool *bm_pool) > +static int mvpp2_check_hw_buf_num(struct mvpp2 *priv, > + struct mvpp2_bm_pool *bm_pool) > { > int buf_num = 0; > > -- > 2.15.1 > -- Antoine Ténart, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com