Re: [PATCH v2 1/2] perf sched: move thread::shortname to thread_runtime

[Namhyung Kim]

Hi,

On Tue, Mar 06, 2018 at 11:37:36AM +0800, changbin...@intel.com wrote:
> From: Changbin Du <changbin...@intel.com>
> 
> The thread::shortname only used by sched command, so move it
> to sched private structure.
> 
> Signed-off-by: Changbin Du <changbin...@intel.com>
> ---

[SNIP]
> diff --git a/tools/perf/util/thread.h b/tools/perf/util/thread.h
> index 40cfa36..14d44c3 100644
> --- a/tools/perf/util/thread.h
> +++ b/tools/perf/util/thread.h
> @@ -26,7 +26,6 @@ struct thread {
>       pid_t                   ppid;
>       int                     cpu;
>       refcount_t              refcnt;
> -     char                    shortname[3];
>       bool                    comm_set;
>       int                     comm_len;
>       bool                    dead; /* if set thread has exited */

I also suggest to move the 'dead' field to pack two bools.

Thanks,
Namhyung