Use kasprintf instead of combination of kmalloc and sprintf and
therefore avoid unnecessary computation of string length.

Signed-off-by: Himanshu Jha <himanshujha199...@gmail.com>
---
 drivers/usb/isp1760/isp1760-udc.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/usb/isp1760/isp1760-udc.c 
b/drivers/usb/isp1760/isp1760-udc.c
index bac4ef5..c35b153 100644
--- a/drivers/usb/isp1760/isp1760-udc.c
+++ b/drivers/usb/isp1760/isp1760-udc.c
@@ -1456,12 +1456,10 @@ int isp1760_udc_register(struct isp1760_device *isp, 
int irq,
                return ret;
 
        devname = dev_name(isp->dev);
-       udc->irqname = kmalloc(strlen(devname) + 7, GFP_KERNEL);
+       udc->irqname = kasprintf(GFP_KERNEL, "%s (udc)", devname);
        if (!udc->irqname)
                return -ENOMEM;
 
-       sprintf(udc->irqname, "%s (udc)", devname);
-
        ret = request_irq(irq, isp1760_udc_irq, IRQF_SHARED | irqflags,
                          udc->irqname, udc);
        if (ret < 0)
-- 
2.7.4

Reply via email to