Hi Sebastian, On Fri, Mar 09, 2018 at 05:08:25PM +0100, Sebastian Reichel wrote: > Hi Quentin, > > On Wed, Feb 28, 2018 at 11:35:58AM +0100, Quentin Schulz wrote: > > We used to use IDs to select a function or a feature depending on the > > variant. It's easier to maintain the code by adding data structure > > storing the few differences between variants so that we don't add a pile > > of if conditions. > > > > Let's use this data structure and update the code to use it. > > > > Signed-off-by: Quentin Schulz <quentin.sch...@bootlin.com> > > Reviewed-by: Chen-Yu Tsai <w...@csie.org> > > --- > > I applied this, but modified the patch slightly, so that > it actually calls your new set_max_voltage() callback in > axp20x_battery_set_prop(). Please check that the resulting > patch looks correct to you: > > https://git.kernel.org/pub/scm/linux/kernel/git/sre/linux-power-supply.git/commit/?h=for-next&id=648badd797c762a713b48afc3b67d56abdd0073b >
You actually fixed an error in this patch while doing so, so thank you :) Looks good to me. Quentin
signature.asc
Description: PGP signature
