3.2.101-rc1 review patch.  If anyone has any objections, please let me know.


From: Andi Kleen <a...@firstfloor.org>

commit 527f6570300980251e818e80865b437eefb4e5d3 upstream.

gcc 4.8 warns

In function 'ath6kl_sdio_enable_scatter':
warning: 'ret' may be used uninitialized in this function
  if (virt_scat || ret) {

The variable can indeed be uninitialized when the previous if branch is
skipped. I just set it to zero for now. I'm not fully sure the fix is
correct, maybe the || should be an && ?

Signed-off-by: Andi Kleen <a...@linux.intel.com>
Signed-off-by: Kalle Valo <kv...@qca.qualcomm.com>
Signed-off-by: Ben Hutchings <b...@decadent.org.uk>
 drivers/net/wireless/ath/ath6kl/sdio.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/net/wireless/ath/ath6kl/sdio.c
+++ b/drivers/net/wireless/ath/ath6kl/sdio.c
@@ -670,7 +670,7 @@ static int ath6kl_sdio_enable_scatter(st
        struct ath6kl_sdio *ar_sdio = ath6kl_sdio_priv(ar);
        struct htc_target *target = ar->htc_target;
-       int ret;
+       int ret = 0;
        bool virt_scat = false;
        /* check if host supports scatter and it meets our requirements */

Reply via email to