Hi
> -----Original Message-----
> From: 李書帆 [mailto:[email protected]]
> Sent: 2018年3月12日 13:22
> To: Jun Li <[email protected]>
> Cc: Greg Kroah-Hartman <[email protected]>;
> [email protected]; [email protected]; [email protected];
> [email protected]; [email protected];
> [email protected]; [email protected]
> Subject: Re: [PATCH v7] staging: typec: handle vendor defined part and modify
> drp toggling flow
>
> Hi Jun,
>
> Thank you.
>
> 2018-03-12 12:33 GMT+08:00 Jun Li <[email protected]>:
> > Hi,
> >
> >> +static irqreturn_t _tcpci_irq(int irq, void *dev_id) {
> >> + struct tcpci *tcpci = dev_id;
> >> +
> >> + return tcpci_irq(tcpci);
> >> +}
> >>
> > ...
> >
> >> + err = devm_request_threaded_irq(&client->dev, client->irq, NULL,
> >> + _tcpci_irq,
> >> IRQF_ONESHOT |
> IRQF_TRIGGER_LOW,
> >> - dev_name(tcpci->dev), tcpci);
> >> + dev_name(&client->dev), chip);
> >
> > - dev_name(&client->dev), chip);
> > + dev_name(&client->dev), chip->tcpci);
> >
> > Did you ever test this patch?
> I've tested this patch with tcpci_rt1711h.c that will be sent out for
> reviewing in
> the next patch after tcpci's modification is passed.
> Because interrupt handler is registered in tcpci_rt1711h.c, here is the place
> I
> didn't notice.
Understood.
> The interrupt handler for tcpci.c should be modified as following:
> static irqreturn_t _tcpci_irq(int irq, void *dev_id) {
> - struct tcpci *tcpci = dev_id;
> + struct tcpci_chip *chip = dev_id;
>
> - return tcpci_irq(tcpci);
> + return tcpci_irq(chip->tcpci);
> }
>
Either way is OK to fix it.
You may send out your v8 and notify Greg to drop your v7 version.
Jun Li
