On Monday 12 March 2018 03:37 PM, Andy Shevchenko wrote:
> On Mon, 2018-03-12 at 10:01 +0530, Harish Jenny K N wrote:
>> This patch exports the host capabilities to debugfs
>> This idea of sharing host capabilities over debugfs
>> came up from Abbas Raza <abbas_r...@mentor.com>
>> Earlier discussions:
>> https://lkml.org/lkml/2018/3/5/357
>> https://www.spinics.net/lists/linux-mmc/msg48219.html
> Address below minors and, FWIW, take mine
> Reviewed-by: Andy Shevchenko <andriy.shevche...@linux.intel.com>


>> +    for_each_set_bit(bit, (const unsigned long *)&caps,
>> +    for_each_set_bit(bit, (const unsigned long *)&caps2,
> Explicit casting is not needed anymore in both cases.

I will address these.
Before sending new patch , I would like to inform that I have been sending this 
patch with the following checkpatch warning, just to keep it same as other 
usages of debugfs_create_file in the drivers/mmc/core/debugfs.c file.

WARNING:SYMBOLIC_PERMS: Symbolic permissions 'S_IRUSR' are not preferred. 
Consider using octal permissions '0400'.

Do I need to address this or keep it same as S_IRUSR ?

Harish Jenny K N

Reply via email to