On Fri, Mar 9, 2018 at 12:34 PM, Phil Edworthy <[email protected]> wrote: > From: Michel Pollet <[email protected]> > > Enable specified clocks from DTS, if any. > > Signed-off-by: Michel Pollet <[email protected]>
> #include <linux/spinlock.h> > #include <linux/platform_data/gpio-dwapb.h> > #include <linux/slab.h> > +#include <linux/clk.h> Keep in order. > + clk = devm_clk_get(&pdev->dev, NULL); > + if (!IS_ERR(clk) && clk_prepare_enable(clk)) > + dev_info(&pdev->dev, "no clock source\n"); First of all, it shadows any error from clk_prepare_enable(), second, it misses the clock name. Next, I don't see how you managed the clock during PM and / or ->remove() operation. -- With Best Regards, Andy Shevchenko
