On 03/13/2018 03:44 AM, Joseph Chen wrote:
Hi, Lee and Daniel:

    I am really sorry for reply so late,  I don't realize that Daniel's emails ended up in my junk mail file.

在 2018/3/12 22:09, Lee Jones 写道:
Rockchip guys,

I'd really appreciate your input on these two patches please.

Please provide Reviewed-by/Tested-by tags.

On Wed, 07 Mar 2018, Daniel Schultz wrote:
After running "poweroff", the PMIC restarts the SoC instead of shutting
it down.

It seems like the description for those two register bits is swapped.
After changing from DEV_OFF to DEV_OFF_RST, the system can poweroff

Signed-off-by: Daniel Schultz<d.schu...@phytec.de>
        v2: Re-submit with recipients from Rockchip.

  drivers/mfd/rk808.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mfd/rk808.c b/drivers/mfd/rk808.c
index 216fbf6..d138721 100644
--- a/drivers/mfd/rk808.c
+++ b/drivers/mfd/rk808.c
@@ -418,7 +418,7 @@ static void rk818_device_shutdown(void)
ret = regmap_update_bits(rk808->regmap,
-                                DEV_OFF, DEV_OFF);
+                                DEV_OFF_RST, DEV_OFF_RST);
        if (ret)
                dev_err(&rk808_i2c_client->dev, "power off error!\n");

I think there maybe something wrong makes your machine restart after "poweroff".     (1) Is your machine attaching charger when you run "poweroff"? RK818 is hardware designed to auto power on when it detects voltage on input pins(8,9);

That's the point! Both pins are driven high... thank you!

We will check how we can handle this on our hardware. For now, I will recall this patch.

Mit freundlichen Grüßen,
With best regards,
  Daniel Schultz

    (2) If restart, you can dump ON_SOURCE(address: 0xAE) and OFF_SOURCE(address: 0xAF) in rk808.c probe() to know  last power off reason and currently power on reason;

Best Regards
陈健洪 (Joseph Chen)
Fuzhou Rockchip Electronics Co.Ltd
福建省福州市铜盘路软件大道89号软件园A区21号楼 (350003)
No. 21 Building, A District, No.89,software Boulevard Fuzhou,Fujian,PRC

Reply via email to