* John Garry <[email protected]> wrote: > On 13/03/2018 14:26, Ingo Molnar wrote: > > > > * Arnaldo Carvalho de Melo <[email protected]> wrote: > > > > > From: John Garry <[email protected]> > > > > > > Add JSON for ARMv8 IMPLEMENTATION DEFINED recommended events. > > > > > > The JSON is copied from ARMv8 architecture reference manual, available > > > here: > > > > > > https://static.docs.arm.com/ddi0487/ca/DDI0487C_a_armv8_arm.pdf > > > > > > Signed-off-by: Shaokun Zhang <[email protected]> > > > Cc: Alexander Shishkin <[email protected]> > > > Cc: Andi Kleen <[email protected]> > > > Cc: Ganapatrao Kulkarni <[email protected]> > > > Cc: Jiri Olsa <[email protected]> > > > Cc: Namhyung Kim <[email protected]> > > > Cc: Peter Zijlstra <[email protected]> > > > Cc: Shaokun Zhang <[email protected]> > > > Cc: Will Deacon <[email protected]> > > > Cc: William Cohen <[email protected]> > > > Cc: [email protected] > > > Cc: [email protected] > > > Link: > > > http://lkml.kernel.org/r/[email protected] > > > Signed-off-by: John Garry <[email protected]> > > > Signed-off-by: Arnaldo Carvalho de Melo <[email protected]> > > > > That's not a valid SOB chain, author != first-Signed-off-by. > > > > Right, so my SOB can go first. > > Let me know how to help remedy.
Well, it depends on what role Shaokun Zhang had in the creation of the patch: if he co-authored the patch and you finished it then you can add him as: Originally-from: Shaokun Zhang <[email protected]> or if he tested/reviewed the patch then his entry should be Reviewed-by/Acked-by or Tested-by. Thanks, Ingo
