Hello Mark,
> -----Original Message-----
> From: Mark Brown [mailto:broo...@kernel.org]
> Sent: Tuesday, March 20, 2018 10:12 AM
> To: Suzuki, Katsuhiro <suzuki.katsuh...@socionext.com>
> Cc: alsa-de...@alsa-project.org; Masami Hiramatsu
<masami.hirama...@linaro.org>;
> Jassi Brar <jaswinder.si...@linaro.org>; linux-arm-ker...@lists.infradead.org;
> linux-kernel@vger.kernel.org
> Subject: Re: [PATCH] ASoC: uniphier: evea: add switch for changing source of
line-in
>
> On Mon, Mar 19, 2018 at 01:19:10PM +0900, Katsuhiro Suzuki wrote:
>
> > > I'll apply for now but this should really be a DAPM control so that we
> > > can power down things connected to the disconnected line inputs when
> > > recording.
>
> > Thanks a lot for your suggestion. I tried to change the implementation to
DAPM
> > control as follows:
>
> > I can see the value of ALINSW1 register at 'Line In 1 Mux',0 using
> > amixer get 'Line In 1 Mux',0
>
> > But I can't change the value.
> > amixer set 'Line In 1 Mux',0 LIN2
> > Simple mixer control 'Line In 1 Mux',0
> > Capabilities: enum
> > Items: 'LIN1' 'LIN2' 'LIN3'
> > Item0: 'LIN1'
>
> > Would you tell me what is wrong...
>
> Ugh, I *have* run into that before but I can't remember what triggers it
> and your code doesn't have any mistakes I can spot. Unfortunately I'm
Thank you for reviewing.
> at Linaro Connect this week and don't have a test system I can poke at
> with me to remind myself, and I'm still travelling next week
> unfortunately.
>
I see, no problem. Have a nice trip!
> I'd add some trace to the set code path to make sure everything is being
> called as expected. It's somemthing really small that's hard to make a
> warning for in the code IIRC.
I traced some DAPM codes. The 'get' function as follows:
int snd_soc_dapm_get_enum_double(struct snd_kcontrol *kcontrol,
struct snd_ctl_elem_value *ucontrol)
{
//...
mutex_lock_nested(&card->dapm_mutex, SND_SOC_DAPM_CLASS_RUNTIME);
if (e->reg != SND_SOC_NOPM && dapm_kcontrol_is_powered(kcontrol)) {
int ret = soc_dapm_read(dapm, e->reg, ®_val);
The soc_dapm_read() reads real value of register. It's simple.
But 'put' function is mysterious for me...
int snd_soc_dapm_put_enum_double(struct snd_kcontrol *kcontrol,
struct snd_ctl_elem_value *ucontrol)
{
//...
change = dapm_kcontrol_set_value(kcontrol, val);
if (e->reg != SND_SOC_NOPM)
reg_change = soc_dapm_test_bits(dapm, e->reg, mask, val);
dapm_kcontrol_set_value() has stored value into dapm_kcontrol_data. And
soc_dapm_test_bits() has just checked value of a register and returned need
update or not. It seems anyone does not update a register in this function.
I tried to change soc_dapm_test_bits() -> soc_dapm_update_bits(), so I can
change value of register using amixer. But I feel this change was wrong. And I
found dapm_seq_run_coalesced() calls soc_dapm_update_bits(). Unfortunately
this function has not been called even if I run amixer.
Anyway, I'll continue to study about DAPM codes.
Regards,
--
Katsuhiro Suzuki
