On Wed, Mar 21, 2018 at 06:47:09AM -0700, Andrey Smirnov wrote: > Add Device Tree bindings for RAVE SP EEPROM driver - an MFD cell of > parent RAVE SP driver (documented in > Documentation/devicetree/bindings/mfd/zii,rave-sp.txt).
I'd prefer to get all the child nodes at once rather than as you upstream the drivers. IOW, please completely describe the device. Then I may have opinions on whether you need these child nodes or not. > Cc: Srinivas Kandagatla <[email protected]> > Cc: [email protected] > Cc: Chris Healy <[email protected]> > Cc: Lucas Stach <[email protected]> > Cc: Aleksander Morgado <[email protected]> > Cc: Rob Herring <[email protected]> > Cc: Mark Rutland <[email protected]> > Cc: [email protected] > Signed-off-by: Andrey Smirnov <[email protected]> > --- > .../bindings/nvmem/zii,rave-sp-eeprom.txt | 23 > ++++++++++++++++++++++ > 1 file changed, 23 insertions(+) > create mode 100644 > Documentation/devicetree/bindings/nvmem/zii,rave-sp-eeprom.txt > > diff --git a/Documentation/devicetree/bindings/nvmem/zii,rave-sp-eeprom.txt > b/Documentation/devicetree/bindings/nvmem/zii,rave-sp-eeprom.txt > new file mode 100644 > index 000000000000..556abfa70524 > --- /dev/null > +++ b/Documentation/devicetree/bindings/nvmem/zii,rave-sp-eeprom.txt > @@ -0,0 +1,23 @@ > +Zodiac Inflight Innovations RAVE EEPROM Bindings > + > +RAVE SP EEPROM device is a "MFD cell" device exposing physical EEPROM > +attached to RAVE Supervisory Processor. It is expected that its Device > +Tree node is specified as a child of the node corresponding to the > +parent RAVE SP device (as documented in > +Documentation/devicetree/bindings/mfd/zii,rave-sp.txt) > + > +Required properties: > + > +- compatible: Should be "zii,rave-sp-eeprom" > + > +Example: > + > + rave-sp { > + compatible = "zii,rave-sp-rdu1"; > + current-speed = <38400>; > + > + dds-eeprom { > + compatible = "zii,rave-sp-eeprom"; > + reg = <0xA3 0x2000>; Child nodes? #nvmem-cells? I assume you have some data in this you need. If not, you don't really need a child node here. Rob
