On Fri, 16 Mar 2018, Daniel Schultz wrote: > Since all three shutdown functions have almost the same code, all logic > from the shutdown functions can be refactored to a new function > "rk808_update_bits", which can update a register by a given address and > bitmask. > > Signed-off-by: Daniel Schultz <[email protected]> > --- > Changes: > v2: Re-submit with recipients from Rockchip. > v3: - Added devicetree property to enable the PMIC reset seperate from > "rockchip,system-power-controller". > - Dropped the first patch of this serie. > v4: Splitted refactoring and the new reset feature. > > drivers/mfd/rk808.c | 47 ++++++++++++++--------------------------------- > 1 file changed, 14 insertions(+), 33 deletions(-)
Both patches look okay to me. It would be good to obtain an Ack or two from the Rockchip guys though. For my own reference: Acked-for-MFD-by: Lee Jones <[email protected]> -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
