On Fri 23 Mar 03:18 PDT 2018, Sricharan R wrote:
> +     soc {
> +             pinctrl@1000000 {
> +                     serial_0_pins: serial0_pinmux {

Please, no underscores in the node name.

> +                             mux {

Fyi, you can put the pinctrl properties directly into the state node,
omitting the "mux" level.

> +                                     pins = "gpio16", "gpio17";
> +                                     function = "blsp_uart0";
> +                                     bias-disable;
> +                             };
> +                     };
> +

Apart from this the patch looks good.

Regards,
Bjorn

Reply via email to