There seems to be a culture amongst BIOS teams to want to crash the
OS when an error can't be handled in firmware. Marking GHES errors as
"fatal" is a very common way to do this.
However, a number of errors reported by GHES may be fatal in the sense
a device or link is lost, but are not fatal to the system. When there
is a disagreement with firmware about the handleability of an error,
print a warning message.
Signed-off-by: Alexandru Gagniuc <mr.nuke...@gmail.com>
---
drivers/acpi/apei/ghes.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/acpi/apei/ghes.c b/drivers/acpi/apei/ghes.c
index 7243a99ea57e..d9123c5fa3d9 100644
--- a/drivers/acpi/apei/ghes.c
+++ b/drivers/acpi/apei/ghes.c
@@ -521,6 +521,11 @@ static int ghes_do_proc(struct ghes *ghes,
corrected_sev = max(corrected_sev, sec_sev);
}
+
+ if ((sev >= GHES_SEV_PANIC) && (corrected_sev < sev)) {
+ pr_warn("FIRMWARE BUG: Firmware sent fatal error that we were
able to correct");
+ pr_warn("BROKEN FIRMWARE: Complain to your hardware vendor");
+ }
return corrected_sev;
}
--
2.14.3
