On Tue, Apr 03, 2018 at 10:46:07AM -0700, Florian Fainelli wrote: > On 02/23/2018 10:27 AM, [email protected] wrote: > > 4.9-stable review patch. If anyone has any objections, please let me know. > > > > ------------------ > > > > From: Arnd Bergmann <[email protected]> > > > > When CONFIG_MTD_CFI is disabled, we get a warning for this spi driver: > > > > include/linux/mtd/cfi.h:76:2: #warning No CONFIG_MTD_CFI_Ix selected. No > > NOR chip support can work. [-Werror=cpp] > > > > The problem here is a layering violation that was fixed in mainline kernels > > with > > a larger rework in commit 054e532f8f90 ("spi: bcm-qspi: Remove hardcoded > > settings > > and spi-nor.h dependency"). We can't really backport that to stable > > kernels, so > > this just adds a Kconfig dependency to make it either build cleanly or > > force it > > to be disabled. > > Sorry for noticing so late, but this appears to be bogus, there is no > MTD_NORFLASH symbol being defined in 4.9, in fact I can't find this > Kconfig symbol in any kernel version, so this effectively results in the > driver no longer being selectable, so this sure does silence the warning. > > Arnd, should we just send reverts of this patch for the affected kernel > or should we be defining MTD_NORFLASH somehow? Am I missing something here?
I'm going to revert this patch for now, thanks. greg k-h
