On Wed, 2018-04-04 at 10:58 +0200, Petr Mladek wrote:
> Move the non-trivial code from the long pointer() function. We are
> going
> to add a check for the access to the address that will make it even
> more
> complicated.
> Also it is better to warn about unknown specifier instead of falling
> back to the %p behavior. It will help people to understand what is
> going wrong. They expect the IP address and not a pointer anyway
> in this situation.

> +     WARN_ONCE(1, "Unsupported pointer format specifier:
> %%p%c%c\n",
> +               fmt[0], fmt[1]);

I think WARN is too much here.

pr_warn_once() ?

Andy Shevchenko <andriy.shevche...@linux.intel.com>
Intel Finland Oy

Reply via email to