From: Wei Yongjun <weiyongj...@huawei.com>

[ Upstream commit e749d328b0b450aa78d562fa26a0cd8872325dd9 ]

Fix to return a negative error code from the request_irq() error
handling case instead of 0, as done elsewhere in this function.

Fixes: dce143c3381c ("ipmi/powernv: Convert to irq event interface")
Signed-off-by: Wei Yongjun <weiyongj...@huawei.com>
Reviewed-by: Alexey Kardashevskiy <a...@ozlabs.ru>
Signed-off-by: Corey Minyard <cminy...@mvista.com>
Signed-off-by: Sasha Levin <alexander.le...@microsoft.com>
---
 drivers/char/ipmi/ipmi_powernv.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/char/ipmi/ipmi_powernv.c b/drivers/char/ipmi/ipmi_powernv.c
index 6e658aa114f1..a70518a4fcec 100644
--- a/drivers/char/ipmi/ipmi_powernv.c
+++ b/drivers/char/ipmi/ipmi_powernv.c
@@ -251,8 +251,9 @@ static int ipmi_powernv_probe(struct platform_device *pdev)
                ipmi->irq = opal_event_request(prop);
        }
 
-       if (request_irq(ipmi->irq, ipmi_opal_event, IRQ_TYPE_LEVEL_HIGH,
-                               "opal-ipmi", ipmi)) {
+       rc = request_irq(ipmi->irq, ipmi_opal_event, IRQ_TYPE_LEVEL_HIGH,
+                        "opal-ipmi", ipmi);
+       if (rc) {
                dev_warn(dev, "Unable to request irq\n");
                goto err_dispose;
        }
-- 
2.15.1

Reply via email to