On Mon, 9 Apr 2018, Geert Uytterhoeven wrote:
> On Sun, Apr 1, 2018 at 3:41 AM, Finn Thain <[email protected]> wrote:
> > The 'eject' shell command may send various different ioctl commands.
> > This leads to error messages on the console even though the FDEJECT
> > ioctl succeeds.
> >
> > ~# eject floppy
> > SWIM floppy_ioctl: unknown cmd 21257
> > SWIM floppy_ioctl: unknown cmd 1
> >
> > Don't log an error message for an invalid ioctl, just do as the
> > swim3 driver does and return -ENOTTY.
> >
> > Cc: Laurent Vivier <[email protected]>
> > Cc: Jens Axboe <[email protected]>
> > Tested-by: Stan Johnson <[email protected]>
> > Signed-off-by: Finn Thain <[email protected]>
>
> Reviewed-by: Geert Uytterhoeven <[email protected]>
>
> Looks like amiflop can use a similar fix.
>
Right. I'll prepare a new patch for that and send it separately.
--
> Gr{oetje,eeting}s,
>
> Geert
>
>