On Mon, 2018-04-09 at 10:29 -0400, Mimi Zohar wrote: > On Sat, 2018-04-07 at 13:36 +0300, Jarkko Sakkinen wrote: > > On Fri, Apr 06, 2018 at 02:03:37PM +0530, Nayna Jain wrote: > > > On 04/05/2018 03:42 PM, Jarkko Sakkinen wrote: > > > > On Mon, Apr 02, 2018 at 09:50:06PM +0530, Nayna Jain wrote: > > > > > Commit e2fb992d82c6 ("tpm: add retry logic") introduced a new loop to > > > > > handle the TPM2_RC_RETRY error. The loop retries the command after > > > > > sleeping for the specified time, which is incremented exponentially in > > > > > every iteration. This patch fixes the initial sleep to be the default > > > > > sleep time. > > > > > > > > I think I understand the code change but do not understand what the > > > > long description. > > > > > > It tells that the first sleep is delay_msec * 2 and not delay_msec. > > > > So the problem is that the loop doubles the time before sleeping > > for the first time. This is missing from the description. Please > > refine it in some way. > > Sure, how about replacing the last line of the patch description with: > Unfortunately, the loop doubles the time before sleeping, causing the > initial sleep to be doubled. This patch fixes the initial sleep time. > > If this change is acceptable, do you want to make the change or should Nayna > repost the patch?
No need. I'll move on to testing. /Jarkko