On Fri, Apr 06, 2018 at 04:16:42PM -0700, Stephen Boyd wrote:
> Quoting Lina Iyer (2018-04-06 08:13:56)
> > From: Mahesh Sivasubramanian <msiva...@codeaurora.org>
> > 
> > Command DB provides information on shared resources like clocks,
> > regulators etc., probed at boot by the remote subsytem and made
> > available in shared memory.
> > 
> > Cc: devicet...@vger.kernel.org
> > Signed-off-by: Mahesh Sivasubramanian <msiva...@codeaurora.org>
> > Signed-off-by: Lina Iyer <il...@codeaurora.org>
> > Reviewed-by: Bjorn Andersson <bjorn.anders...@linaro.org>
> > ---
> > 
> 
> Reviewed-by: Stephen Boyd <swb...@chromium.org>
> 
> > +       reserved-memory {
> > +               [...]
> > +               qcom,cmd-db@85fe0000 {
> 
> Nitpick: This may want to be called 'memory@85fe0000' because we prefer
> generic node names.

Well, "memory" is for nodes of memory that aren't reserved. So 
"reserved-memory@..." would be better.

Otherwise,

Reviewed-by: Rob Herring <r...@kernel.org>

Reply via email to