4.14-stable review patch.  If anyone has any objections, please let me know.


From: Hans de Goede <hdego...@redhat.com>

[ Upstream commit 165c2357744e41391902a2a72dd170beb60c28d5 ]

Properly stop any work we may have queued on probe-errors / remove.

Rather then adding a remove driver callback for this, and goto style
error handling to probe, use a devm_action for this.

The devm_action gets registered before we register any of the extcon
notifiers which may queue the work, devm does cleanup in reverse order,
so this ensures that the notifiers are removed before we cancel the work.

Reviewed-by: Chen-Yu Tsai <w...@csie.org>
Signed-off-by: Hans de Goede <hdego...@redhat.com>
Signed-off-by: Sebastian Reichel <sebastian.reic...@collabora.co.uk>
Signed-off-by: Sasha Levin <alexander.le...@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gre...@linuxfoundation.org>
 drivers/power/supply/axp288_charger.c |   13 +++++++++++++
 1 file changed, 13 insertions(+)

--- a/drivers/power/supply/axp288_charger.c
+++ b/drivers/power/supply/axp288_charger.c
@@ -785,6 +785,14 @@ static int charger_init_hw_regs(struct a
        return 0;
+static void axp288_charger_cancel_work(void *data)
+       struct axp288_chrg_info *info = data;
+       cancel_work_sync(&info->otg.work);
+       cancel_work_sync(&info->cable.work);
 static int axp288_charger_probe(struct platform_device *pdev)
        int ret, i, pirq;
@@ -836,6 +844,11 @@ static int axp288_charger_probe(struct p
                return ret;
+       /* Cancel our work on cleanup, register this before the notifiers */
+       ret = devm_add_action(dev, axp288_charger_cancel_work, info);
+       if (ret)
+               return ret;
        /* Register for extcon notification */
        INIT_WORK(&info->cable.work, axp288_charger_extcon_evt_worker);
        info->cable.nb[0].notifier_call = axp288_charger_handle_cable0_evt;

Reply via email to