fcpcipnp_setup() is never called in atomic context.
The call chain ending up at fcpcipnp_setup() is:
[1] fcpcipnp_setup() <- fcpnp_probe()
fcpnp_probe() is set as ".probe" in struct pnp_driver.
This function is not called in atomic context.
Despite never getting called from atomic context, fcpcipnp_setup()
calls mdelay() to busily wait.
This is not necessary and can be replaced with usleep_range() to
avoid busy waiting.
This is found by a static analysis tool named DCNS written by myself.
And I also manually check it.
Signed-off-by: Jia-Ju Bai <baijiaju1...@gmail.com>
---
drivers/isdn/hisax/hisax_fcpcipnp.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/isdn/hisax/hisax_fcpcipnp.c
b/drivers/isdn/hisax/hisax_fcpcipnp.c
index e4f7573..06068a42 100644
--- a/drivers/isdn/hisax/hisax_fcpcipnp.c
+++ b/drivers/isdn/hisax/hisax_fcpcipnp.c
@@ -772,11 +772,11 @@ static int fcpcipnp_setup(struct fritz_adapter *adapter)
// Reset
outb(0, adapter->io + AVM_STATUS0);
- mdelay(10);
+ usleep_range(10000, 11000);
outb(AVM_STATUS0_RESET, adapter->io + AVM_STATUS0);
- mdelay(10);
+ usleep_range(10000, 11000);
outb(0, adapter->io + AVM_STATUS0);
- mdelay(10);
+ usleep_range(10000, 11000);
switch (adapter->type) {
case AVM_FRITZ_PCIV2:
--
1.9.1
