3.18-stable review patch.  If anyone has any objections, please let me know.


From: Jason Yan <yanai...@huawei.com>

[ Upstream commit 2b23d9509fd7174b362482cf5f3b5f9a2265bc33 ]

The intend purpose here was to goto out if smp_execute_task() returned
error. Obviously something got screwed up. We will never get these link
error statistics below:

~:/sys/class/sas_phy/phy-1:0:12 # cat invalid_dword_count
~:/sys/class/sas_phy/phy-1:0:12 # cat running_disparity_error_count
~:/sys/class/sas_phy/phy-1:0:12 # cat loss_of_dword_sync_count
~:/sys/class/sas_phy/phy-1:0:12 # cat phy_reset_problem_count

Obviously we should goto error handler if smp_execute_task() returns

Fixes: 2908d778ab3e ("[SCSI] aic94xx: new driver")
Signed-off-by: Jason Yan <yanai...@huawei.com>
CC: John Garry <john.ga...@huawei.com>
CC: chenqilin <chenqil...@huawei.com>
CC: chenxiang <chenxian...@hisilicon.com>
Reviewed-by: Hannes Reinecke <h...@suse.com>
Reviewed-by: Christoph Hellwig <h...@lst.de>
Signed-off-by: Martin K. Petersen <martin.peter...@oracle.com>
Signed-off-by: Sasha Levin <alexander.le...@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gre...@linuxfoundation.org>
 drivers/scsi/libsas/sas_expander.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/scsi/libsas/sas_expander.c
+++ b/drivers/scsi/libsas/sas_expander.c
@@ -675,7 +675,7 @@ int sas_smp_get_phy_events(struct sas_ph
        res = smp_execute_task(dev, req, RPEL_REQ_SIZE,
                                    resp, RPEL_RESP_SIZE);
-       if (!res)
+       if (res)
                goto out;
        phy->invalid_dword_count = scsi_to_u32(&resp[12]);

Reply via email to