On 10.04.2018 17:49, Eyal Ilsar wrote:
> Remove unnecessary braces {} around an 'if' statement block with a single
> statement. Issue found by checkpatch.
You should add an empty line before "Signed-off" line as stated in [1]. I
would also add a space b/w your name and your email in Signed-off line as
is exemplified in [2].
[1]
https://www.kernel.org/doc/html/latest/process/submitting-patches.html#the-canonical-patch-format
[2] https://www.kernel.org/doc/html/latest/process/sub
mitting-patches.html#developer-s-certificate-of-origin-1-1
> Signed-off-by: Eyal Ilsar<edil...@gmail.com>
> ---
> This is part of my take on the Eudyptula challenge
>
> drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c
> b/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c
> index 205304c..325afe1 100644
> --- a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c
> +++ b/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c
> @@ -284,9 +284,8 @@ static void remove_network_from_shadow(struct timer_list
> *unused)
> }
> }
>
> - if (last_scanned_cnt != 0) {
> + if (last_scanned_cnt != 0)
> mod_timer(&hAgingTimer, jiffies + msecs_to_jiffies(AGING_TIME));
> - }
> }
>
> static void clear_duringIP(struct timer_list *unused)
>
