On Fri, Apr 13, 2018 at 05:15:03PM +0200, Johan Hovold wrote: > Since commit 39cee200c23e ("usb: musb: core: call init and shutdown for > the usb phy") the musb USB phy is initialised by musb_core, but the > original initialisation in the dsps-glue init callback was left in > place resulting in two calls to phy init during probe (and similarly, > two shutdowns on remove). > > Drop the duplicate phy init and shutdown calls from the dsps glue in > favour of the ones in musb core, which other glue drivers rely on.
Hmm, I don't remember the details of my debug session that led to 39cee200c23e, and I don't have access to the hardware in question any more. But your commit logs makes sense, so Acked-by: Uwe Kleine-König <u.kleine-koe...@pengutronix.de> Given that it took 2+ years to find this, backporting to stable and a Fixes: line are probably not necessary. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ |