Having an extra ifdef makes the code harder to read. For the case
of ll_xattr_get_common() we have a variable initialized at the
start of the function but it is only used in XATTR_ACL_ACCESS_T
code block. Lets move that variable to that location since its
only used there and make the code look cleaner.

Signed-off-by: James Simmons <uja.o...@yahoo.com>
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-9183
Reviewed-on: https://review.whamcloud.com/27240
Reviewed-by: Dmitry Eremin <dmitry.ere...@intel.com>
Reviewed-by: Bob Glossman <bob.gloss...@intel.com>
Reviewed-by: Sebastien Buisson <sbuis...@ddn.com>
Reviewed-by: Oleg Drokin <oleg.dro...@intel.com>
Signed-off-by: James Simmons <jsimm...@infradead.org>
 drivers/staging/lustre/lustre/llite/xattr.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/staging/lustre/lustre/llite/xattr.c 
index 3ab7ae0..147ffcc 100644
--- a/drivers/staging/lustre/lustre/llite/xattr.c
+++ b/drivers/staging/lustre/lustre/llite/xattr.c
@@ -396,9 +396,6 @@ static int ll_xattr_get_common(const struct xattr_handler 
                               const char *name, void *buffer, size_t size)
        struct ll_sb_info *sbi = ll_i2sbi(inode);
-       struct ll_inode_info *lli = ll_i2info(inode);
        char *fullname;
        int rc;
@@ -422,6 +419,7 @@ static int ll_xattr_get_common(const struct xattr_handler 
         * chance that cached ACL is uptodate.
        if (handler->flags == XATTR_ACL_ACCESS_T) {
+               struct ll_inode_info *lli = ll_i2info(inode);
                struct posix_acl *acl;

Reply via email to