On 4/16/2018 9:27 AM, Bjorn Helgaas wrote: >>> We realized that DPC and hotplug is heavily integrated today. We >>> have use cases for systems without hotplug support but still >>> support DPC. That's the problem we are trying to solve with this >>> patchset. > Apparently there's a problem with systems that have DPC but not > hotplug. It will be extremely helpful if you can articulate what that > problem is and include it in the appropriate changelog. >
At a higher level, the DPC driver performs the stop operation regardless of hotplug. However, DPC driver relies on hotplug driver observing link up to re-enumerate. Of course, when the system didn't support hotplug; there was nobody to restore functionality. Our initial attempt was to also do a re-enumeration in the DPC driver regardless of hotplug driver in the system or not. If hotplug driver is present, it would observe two enumerations. It still worked as long as these were protected by a mutex. Then, we got your input that you want DPC and AER to behave the same. We started converging towards the AER path. -- Sinan Kaya Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.