On Mon, 16 Apr 2018 12:31:09 -0700 Linus Torvalds <torva...@linux-foundation.org> wrote: > > But the -stable tree? > > Seriously, what do you expect them to do if they get a report that a > commit they added to the stable tree regresses? > > "Revert first, ask questions later" is definitely a very sane model there.
The topic of our discussion is on what to backport, and how likely is it to cause regressions. I'm arguing that the bar for backporting should be raised, and that only "critical" fixes should be backported. Sasha pointed this bug fix as an example, and asked me if I would backport it under my conditions. I said yes. He then said "it was reverted", pointing me to the commit that fixed it. That confused me. When I looked further, I noticed that it wasn't reverted, and since he pointed me to the API fix, I said "I hope it wasn't reverted" meaning I hope they backported the obvious API fix and didn't just revert the original fix. -- Steve