Hi Mike,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on mmotm/master]
[also build test ERROR on v4.17-rc1 next-20180417]
[if your patch is applied to the wrong git tree, please drop us a note to help 
improve the system]

url:    
https://github.com/0day-ci/linux/commits/Mike-Kravetz/mm-change-type-of-free_contig_range-nr_pages-to-unsigned-long/20180417-194309
base:   git://git.cmpxchg.org/linux-mmotm.git master
config: i386-tinyconfig (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All errors (new ones prefixed by >>):

   In file included from include/linux/slab.h:15:0,
                    from include/linux/crypto.h:24,
                    from arch/x86/kernel/asm-offsets.c:9:
>> include/linux/gfp.h:580:15: error: unknown type name 'page'
    static inline page *find_alloc_contig_pages(unsigned int order, gfp_t gfp,
                  ^~~~
   include/linux/gfp.h:585:13: warning: 'free_contig_pages' defined but not 
used [-Wunused-function]
    static void free_contig_pages(struct page *page, unsigned long nr_pages)
                ^~~~~~~~~~~~~~~~~
   make[2]: *** [arch/x86/kernel/asm-offsets.s] Error 1
   make[2]: Target '__build' not remade because of errors.
   make[1]: *** [prepare0] Error 2
   make[1]: Target 'prepare' not remade because of errors.
   make: *** [sub-make] Error 2

vim +/page +580 include/linux/gfp.h

   570  
   571  #if (defined(CONFIG_MEMORY_ISOLATION) && defined(CONFIG_COMPACTION)) || 
defined(CONFIG_CMA)
   572  /* The below functions must be run on a range from a single zone. */
   573  extern int alloc_contig_range(unsigned long start, unsigned long end,
   574                                unsigned migratetype, gfp_t gfp_mask);
   575  extern void free_contig_range(unsigned long pfn, unsigned long 
nr_pages);
   576  extern struct page *find_alloc_contig_pages(unsigned int order, gfp_t 
gfp,
   577                                                  int nid, nodemask_t 
*nodemask);
   578  extern void free_contig_pages(struct page *page, unsigned long 
nr_pages);
   579  #else
 > 580  static inline page *find_alloc_contig_pages(unsigned int order, gfp_t 
 > gfp,
   581                                                  int nid, nodemask_t 
*nodemask)
   582  {
   583          return NULL;
   584  }
   585  static void free_contig_pages(struct page *page, unsigned long nr_pages)
   586  {
   587  }
   588  #endif
   589  

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip

Reply via email to