On Tue, Apr 17, 2018 at 10:12:04AM -0700, Douglas Anderson wrote: > In of_get_regulation_constraints() it can clearly be seen that the > return value of of_map_mode() is assigned to a signed integer. This > is important because the first thing the regulator core does with this > value is to compare it to -EINVAL. > > Let's fix the return type of all of the current of_map_mode() > functions. While we're at it, we'll remove one pointless "inline".
Ah, I see... the thing here is that the mode is always an unsigned int since it's a bitmask - this goes out beying the use in of_map_mode() and into all the other APIs. We only actually use 4 bits currently so I think there's no problem switching to int but it seems we should probably do that consistently throughout the API so that things don't get missed later on.
signature.asc
Description: PGP signature
