On 04/19/2018 07:43 PM, Johannes Thumshirn wrote: > Provide a descriptive error in case an lport to rport association > isn't found when creating the FC-NVME controller. > > Currently it's very hard to debug the reason for a failed connect > attempt without a look at the source. > > Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de> > > --- > This actually happened to Hannes and me because of a typo in a > customer demo today, so yes things like this happen until we have a > proper way to do auto-connect. > --- > drivers/nvme/host/fc.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/nvme/host/fc.c b/drivers/nvme/host/fc.c > index 6cb26bcf6ec0..8b66879b4ebf 100644 > --- a/drivers/nvme/host/fc.c > +++ b/drivers/nvme/host/fc.c > @@ -3284,6 +3284,8 @@ nvme_fc_create_ctrl(struct device *dev, struct > nvmf_ctrl_options *opts) > } > spin_unlock_irqrestore(&nvme_fc_lock, flags); > > + pr_warn("%s: %s - %s combination not found\n", > + __func__, opts->traddr, opts->host_traddr); > return ERR_PTR(-ENOENT); > } > > Reviewed-by: Hannes Reinecke <h...@suse.com>
Cheers, Hannes -- Dr. Hannes Reinecke Teamlead Storage & Networking h...@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg)