4.16-stable review patch.  If anyone has any objections, please let me know.

------------------

From: Heinz Mauelshagen <[email protected]>

commit 880bcce0dcc3172fe865352b492c41d85290cb8d upstream.

Fix a race for "nosync" activations providing "aa.." device health
characters and "0/N" sync ratio rather than "AA..." and "N/N".  Occurs
when status for the raid set is retrieved during resume before the MD
sync thread starts and clears the MD_RECOVERY_NEEDED flag.

Cc: [email protected] # 4.16+
Signed-off-by: Heinz Mauelshagen <[email protected]>
Signed-off-by: Mike Snitzer <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

---
 drivers/md/dm-raid.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

--- a/drivers/md/dm-raid.c
+++ b/drivers/md/dm-raid.c
@@ -3408,7 +3408,8 @@ static sector_t rs_get_progress(struct r
                set_bit(RT_FLAG_RS_IN_SYNC, &rs->runtime_flags);
 
        } else {
-               if (!test_bit(MD_RECOVERY_INTR, &recovery) &&
+               if (!test_bit(__CTR_FLAG_NOSYNC, &rs->ctr_flags) &&
+                   !test_bit(MD_RECOVERY_INTR, &recovery) &&
                    (test_bit(MD_RECOVERY_NEEDED, &recovery) ||
                     test_bit(MD_RECOVERY_RESHAPE, &recovery) ||
                     test_bit(MD_RECOVERY_RUNNING, &recovery)))


Reply via email to