Hi Geert, On 23 April 2018 at 17:07, Geert Uytterhoeven <[email protected]> wrote: > Hi Baolin, > > On Mon, Apr 23, 2018 at 4:08 AM, Baolin Wang <[email protected]> wrote: >> On 20 April 2018 at 23:22, Arnd Bergmann <[email protected]> wrote: >>> On Thu, Apr 19, 2018 at 8:22 AM, Baolin Wang <[email protected]> wrote: >>>> The read_persistent_clock() uses a timespec, which is not year 2038 safe >>>> on 32bit systems. Moreover on m68k architecture, we have implemented >>>> generic >>>> RTC drivers that can be used to compensate the system suspend time. So >>>> we can remove the obsolete read_persistent_clock(). >>>> >>>> Signed-off-by: Baolin Wang <[email protected]> >>> >>> I'm not sure about this one: it's still possible to turn off >>> CONFIG_RTC_DRV_GENERIC >>> on M68KCLASSIC, and in that case we still need a read_persistent_clock64() >>> implementation. Or we use your patch but make CONFIG_RTC_DRV_GENERIC >>> mandatory. >> >> OK. Thanks for fixing the issue with your patch. > > Can I consider that an Acked-by?
I will add one reviewed-by tag in Arnd's new patch. -- Baolin.wang Best Regards
