On 23 April 2018 12:28, Greg Kroah-Hartman wrote: > On Mon, Apr 23, 2018 at 11:06:25AM +0000, Adam Thomson wrote: > > On 23 April 2018 09:25, Greg Kroah-Hartman wrote: > > > > > On Mon, Apr 23, 2018 at 07:49:38AM +0000, Adam Thomson wrote: > > > > On 22 April 2018 21:58, Adam Thomson wrote: > > > > > > > > > On 22 April 2018 15:05, Greg Kroah-Hartman wrote: > > > > > > > > > > > On Fri, Mar 23, 2018 at 10:12:20AM +0000, Adam Thomson wrote: > > > > > > > This commit adds code to handle requesting of PPS APDOs. Switching > > > > > > > between standard PDOs and APDOs, and re-requesting an APDO to > > > > > > > modify operating voltage/current will be triggered by an > > > > > > > external call into TCPM. > > > > > > > > > > > > > > Signed-off-by: Adam Thomson > <adam.thomson.opensou...@diasemi.com> > > > > > > > Acked-by: Heikki Krogerus <heikki.kroge...@linux.intel.com> > > > > > > > Reviewed-by: Guenter Roeck <li...@roeck-us.net> > > > > > > > --- > > > > > > > drivers/usb/typec/tcpm.c | 517 > > > > > > ++++++++++++++++++++++++++++++++++++++++++++++- > > > > > > > include/linux/usb/pd.h | 4 +- > > > > > > > include/linux/usb/tcpm.h | 1 + > > > > > > > 3 files changed, 509 insertions(+), 13 deletions(-) > > > > > > > > > > > > This patch adds build warnings to the tree, so I can't take it, > > > > > > sorry. > > > > > > Please fix up and resend. > > > > > > > > > > No problem. Sorry for that. Will take a look and resolve the warnings. > > > > > > > > Sadly this is going to be a bit more than 'resolve the warnings' task > > > > now as Jun > > > > Li's patch set has now made it in before me which means I need to > > > > rebase PDO > > > > Selection because of his changes. :( > > > > > > Someone was going to have to do that, sorry :( > > > > Just as an FYI, this patch will produce warnings until the associated > > power_supply interface patch (number 5 in the series previously sent) is > > included as that makes use of the new API. Not sure how I can get around > > that > > so I guess we have to wait on Sebastian to give the nod for the rest of the > > power_supply patches before this can make it through. > > That's not good. There has to be a way to prevent a build warning from > happening...
If we're ok with '__maybe_unused' then I can add that. Wasn't sure if something like that would be acceptable for this scenario.
