Hi Mika,
On Wed, Apr 25, 2018 at 12:51:41PM +0300, Mika Westerberg wrote:
> On Sat, Apr 21, 2018 at 09:50:07AM +0100, Javier Arteaga wrote:
> > +static const struct acpi_device_id upboard_acpi_match[] = {
> > + { "AANT0F01", (kernel_ulong_t) &upboard_up2_data },
>
> No space after cast so write it like,
>
> { "AANT0F01", (kernel_ulong_t)&upboard_up2_data },
> > + upboard_data = (const struct upboard_data *) id->driver_data;
>
> Ditto and to other places.
Thanks! I've fixed it for the next series now.
Actually, checkpatch did not catch this one, and I can't see an explicit
mention to this rule in coding-style.rst either. Is this worth sending a
patch to the style guide?
> Otherwise looks good to me.
Thanks for your review!
