On Monday 30 April 2018 01:54 PM, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski <bgolaszew...@baylibre.com> > > We have the 'ti,davinci-chipselect' property in the device tree, but > when using platform data the driver silently uses the id field of > struct platform_device as the chipselect. This is confusing and we > almost broke the nand support again recently after converting the > platform to common clock framework (which changed the device id in the > clock lookup - the problem is gone now that we no longer acquire the > clock in the nand driver. > > This patch adds a new filed - core_chipsel - to the platform_data.
s/filed/field > Subsequent patches will convert the platforms to using this new field. Can you add a comment for this new field too, like how we have for most other fields? Curious on what 'core' in core_chipsel means. Something to do with chip-select offset we have on DA850? > > Signed-off-by: Bartosz Golaszewski <bgolaszew...@baylibre.com> Thanks, Sekhar