Thanks! Updated in v5 2/3.
> -----Original Message----- > From: Rob Herring [mailto:r...@kernel.org] > Sent: Tuesday, May 1, 2018 12:25 PM > To: Liming Sun <l...@mellanox.com> > Cc: Ulf Hansson <ulf.hans...@linaro.org>; Mark Rutland > <mark.rutl...@arm.com>; Jaehoon Chung <jh80.ch...@samsung.com>; > Catalin Marinas <catalin.mari...@arm.com>; Will Deacon > <will.dea...@arm.com>; linux-...@vger.kernel.org; > devicet...@vger.kernel.org; linux-kernel@vger.kernel.org > Subject: Re: [PATCH v4 2/3] dt-bindings: mmc: Add binding for BlueField SoC > > On Tue, May 01, 2018 at 10:32:34AM -0400, Liming Sun wrote: > > This commit adds "mellanox,bluefield-dw-mshc" for dwmmc driver > > extension on Mellanox BlueField SoC platform. > > > > Signed-off-by: Liming Sun <l...@mellanox.com> > > --- > > .../devicetree/bindings/mmc/bluefield-dw-mshc.txt | 29 > ++++++++++++++++++++++ > > 1 file changed, 29 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/mmc/bluefield- > dw-mshc.txt > > > > diff --git a/Documentation/devicetree/bindings/mmc/bluefield-dw- > mshc.txt b/Documentation/devicetree/bindings/mmc/bluefield-dw- > mshc.txt > > new file mode 100644 > > index 0000000..75bd844d > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/mmc/bluefield-dw-mshc.txt > > @@ -0,0 +1,29 @@ > > +* Mellanox Bluefield SoC specific extensions to the Synopsys Designware > > + Mobile Storage Host Controller > > + > > +Read synopsys-dw-mshc.txt for more details > > + > > +The Synopsys designware mobile storage host controller is used to > interface > > +a SoC with storage medium such as eMMC or SD/MMC cards. This file > documents > > +differences between the core Synopsys dw mshc controller properties > described > > +by synopsys-dw-mshc.txt and the properties used by the Mellanox > Bluefield SoC > > +specific extensions to the Synopsys Designware Mobile Storage Host > Controller. > > + > > +Required Properties: > > + > > +* compatible: should be one of the following. > > + - "mellanox,bluefield-dw-mshc": for controllers with Mellanox Bluefield > SoC > > + specific extensions. > > + > > +Example: > > + > > + /* Mellanox Bluefield SoC MMC */ > > + mmc@0x6008000 { > > Drop the '0x'. > > Building your dtb with 'W=1' will warn on this. > > With that, > > Reviewed-by: Rob Herring <r...@kernel.org> > > > + compatible = "mellanox,bluefield-dw-mshc"; > > + reg = <0x6008000 0x400>; > > + interrupts = <32>; > > + fifo-depth = <0x100>; > > + clock-frequency = <24000000>; > > + bus-width = <8>; > > + cap-mmc-highspeed; > > + }; > > -- > > 1.8.3.1 > >
