On Wed, 2 May 2018 21:44:58 +0800 [email protected] wrote: > From: Changbin Du <[email protected]> > > This patch add a new kernel hacking option NO_AUTO_INLINE. Selecting > this option will prevent the compiler from optimizing the kernel by > auto-inlining functions not marked with the inline keyword. > > With this option, only functions explicitly marked with "inline" will > be inlined. This will allow the function tracer to trace more functions > because it only traces functions that the compiler has not inlined. > > Signed-off-by: Changbin Du <[email protected]> > Cc: Steven Rostedt <[email protected]>
I'm fine with this patch if others are OK with it too. Acked-by: Steven Rostedt (VMware) <[email protected]> -- Steve > > --- > v2: Some grammar updates from Steven. > --- > Makefile | 6 ++++++ > lib/Kconfig.debug | 18 ++++++++++++++++++ > 2 files changed, 24 insertions(+) > > diff --git a/Makefile b/Makefile > index 619a85a..eb694f6 100644 > --- a/Makefile > +++ b/Makefile > @@ -775,6 +775,12 @@ KBUILD_CFLAGS += $(call cc-option, > -femit-struct-debug-baseonly) \ > $(call cc-option,-fno-var-tracking) > endif > > +ifdef CONFIG_NO_AUTO_INLINE > +KBUILD_CFLAGS += $(call cc-option, -fno-inline-functions) \ > + $(call cc-option, -fno-inline-small-functions) \ > + $(call cc-option, -fno-inline-functions-called-once) > +endif > + > ifdef CONFIG_FUNCTION_TRACER > ifndef CC_FLAGS_FTRACE > CC_FLAGS_FTRACE := -pg > diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug > index c40c7b7..ab55801 100644 > --- a/lib/Kconfig.debug > +++ b/lib/Kconfig.debug > @@ -198,6 +198,24 @@ config GDB_SCRIPTS > instance. See Documentation/dev-tools/gdb-kernel-debugging.rst > for further details. > > +config NO_AUTO_INLINE > + bool "Disable compiler auto-inline optimizations" > + default n > + help > + This will prevent the compiler from optimizing the kernel by > + auto-inlining functions not marked with the inline keyword. > + With this option, only functions explicitly marked with > + "inline" will be inlined. This will allow the function tracer > + to trace more functions because it only traces functions that > + the compiler has not inlined. > + > + Enabling this function can help debugging a kernel if using > + the function tracer. But it can also change how the kernel > + works, because inlining functions may change the timing, > + which could make it difficult while debugging race conditions. > + > + If unsure, select N. > + > config ENABLE_WARN_DEPRECATED > bool "Enable __deprecated logic" > default y
