On Thu, Apr 26, 2018 at 02:58:13PM +0800, Anson Huang wrote:
> Add pfuze100 support on i.MX6SX Sabre Auto board.
> 
> Signed-off-by: Anson Huang <[email protected]>
> ---
> no changes since V4.
>  arch/arm/boot/dts/imx6sx-sabreauto.dts | 117 
> +++++++++++++++++++++++++++++++++
>  1 file changed, 117 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/imx6sx-sabreauto.dts 
> b/arch/arm/boot/dts/imx6sx-sabreauto.dts
> index 57d1ea0..2caca934 100644
> --- a/arch/arm/boot/dts/imx6sx-sabreauto.dts
> +++ b/arch/arm/boot/dts/imx6sx-sabreauto.dts
> @@ -74,6 +74,14 @@
>  
>  &iomuxc {
>       imx6x-sabreauto {
> +

Drop this newline.

> +             pinctrl_i2c2_1: i2c2grp-1 {

The suffix "1" doesn't make any sense now.

        pinctrl_i2c2: i2c2grp {

> +                     fsl,pins = <
> +                             MX6SX_PAD_GPIO1_IO03__I2C2_SDA          
> 0x4001b8b1
> +                             MX6SX_PAD_GPIO1_IO02__I2C2_SCL          
> 0x4001b8b1
> +                     >;
> +             };
> +
>               pinctrl_uart1: uart1grp {
>                       fsl,pins = <
>                               MX6SX_PAD_GPIO1_IO04__UART1_TX          0x1b0b1
> @@ -148,3 +156,112 @@
>               };
>       };
>  };
> +
> +&i2c2 {
> +     clock-frequency = <100000>;
> +     pinctrl-names = "default";
> +     pinctrl-0 = <&pinctrl_i2c2_1>;
> +     status = "okay";
> +
> +     pmic: pfuze100@08 {

Use generic name for node, and specific name for label.  Also, drop the
leading zeros in unit-address.

        pfuze100: pmic@8 {

Shawn

> +             compatible = "fsl,pfuze100";
> +             reg = <0x08>;
> +
> +             regulators {
> +                     sw1a_reg: sw1ab {
> +                             regulator-min-microvolt = <300000>;
> +                             regulator-max-microvolt = <1875000>;
> +                             regulator-boot-on;
> +                             regulator-always-on;
> +                             regulator-ramp-delay = <6250>;
> +                     };
> +
> +                     sw1c_reg: sw1c {
> +                             regulator-min-microvolt = <300000>;
> +                             regulator-max-microvolt = <1875000>;
> +                             regulator-boot-on;
> +                             regulator-always-on;
> +                             regulator-ramp-delay = <6250>;
> +                     };
> +
> +                     sw2_reg: sw2 {
> +                             regulator-min-microvolt = <800000>;
> +                             regulator-max-microvolt = <3300000>;
> +                             regulator-boot-on;
> +                             regulator-always-on;
> +                     };
> +
> +                     sw3a_reg: sw3a {
> +                             regulator-min-microvolt = <400000>;
> +                             regulator-max-microvolt = <1975000>;
> +                             regulator-boot-on;
> +                             regulator-always-on;
> +                     };
> +
> +                     sw3b_reg: sw3b {
> +                             regulator-min-microvolt = <400000>;
> +                             regulator-max-microvolt = <1975000>;
> +                             regulator-boot-on;
> +                             regulator-always-on;
> +                     };
> +
> +                     sw4_reg: sw4 {
> +                             regulator-min-microvolt = <800000>;
> +                             regulator-max-microvolt = <3300000>;
> +                             regulator-always-on;
> +                     };
> +
> +                     swbst_reg: swbst {
> +                             regulator-min-microvolt = <5000000>;
> +                             regulator-max-microvolt = <5150000>;
> +                     };
> +
> +                     snvs_reg: vsnvs {
> +                             regulator-min-microvolt = <1000000>;
> +                             regulator-max-microvolt = <3000000>;
> +                             regulator-boot-on;
> +                             regulator-always-on;
> +                     };
> +
> +                     vref_reg: vrefddr {
> +                             regulator-boot-on;
> +                             regulator-always-on;
> +                     };
> +
> +                     vgen1_reg: vgen1 {
> +                             regulator-min-microvolt = <800000>;
> +                             regulator-max-microvolt = <1550000>;
> +                             regulator-always-on;
> +                     };
> +
> +                     vgen2_reg: vgen2 {
> +                             regulator-min-microvolt = <800000>;
> +                             regulator-max-microvolt = <1550000>;
> +                     };
> +
> +                     vgen3_reg: vgen3 {
> +                             regulator-min-microvolt = <1800000>;
> +                             regulator-max-microvolt = <3300000>;
> +                             regulator-always-on;
> +                     };
> +
> +                     vgen4_reg: vgen4 {
> +                             regulator-min-microvolt = <1800000>;
> +                             regulator-max-microvolt = <3300000>;
> +                             regulator-always-on;
> +                     };
> +
> +                     vgen5_reg: vgen5 {
> +                             regulator-min-microvolt = <1800000>;
> +                             regulator-max-microvolt = <3300000>;
> +                             regulator-always-on;
> +                     };
> +
> +                     vgen6_reg: vgen6 {
> +                             regulator-min-microvolt = <1800000>;
> +                             regulator-max-microvolt = <3300000>;
> +                             regulator-always-on;
> +                     };
> +             };
> +     };
> +};
> -- 
> 2.7.4
> 

Reply via email to