On 7 May 2018 at 15:49, Daniel Lezcano <[email protected]> wrote: > On Mon, May 07, 2018 at 02:04:38PM +0800, Chunyan Zhang wrote: >> Hi Daniel, >> >> On 7 May 2018 at 13:51, Daniel Lezcano <[email protected]> wrote: >> > On Thu, May 03, 2018 at 08:27:32PM +0800, Chunyan Zhang wrote: >> >> SPRD arch doesn't select SPRD_TIMER, so this config would not >> >> appear even if ARCH_SPRD is set and COMPILE_TEST is not. >> >> >> >> Fix the Kconfig selection rule by letting the SPRD arch to select. >> > >> > Instead of changing this Kconfig, please fix the arch's Kconfig by >> > selecting >> > SPRD_TIMER. >> >> Oh, that's not my expectation, I hope we can give users permission of >> not selecting SPRD TIMER driver even if SPRD arch is selected. (I can >> confirm that all Spreadtrum's platforms in mainline can work without >> this driver. An enough minimum workable system doesn't need this >> driver indeed.) > > Ok, can you add the EXPERT option in addition to the bool like:
Sure, that makes more sense indeed :) Thanks for the review, Chunyan > > https://lkml.org/lkml/2018/4/3/897 > > Thanks. > > -- Daniel > > > -- > > <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs > > Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | > <http://twitter.com/#!/linaroorg> Twitter | > <http://www.linaro.org/linaro-blog/> Blog
