On Thu, 3 May 2018 14:24:04 +0530 Ravi Bangoria <[email protected]> wrote:
> Hi Masami, > > On 04/23/2018 12:32 PM, Masami Hiramatsu wrote: > > On Tue, 17 Apr 2018 09:43:46 +0530 > > Ravi Bangoria <[email protected]> wrote: > > > >> + pr_debug("Purged all: %s\n", err ? "FAIL" : "Ok"); > > Hmm, I think this should use pr_info(or pr_warning), at least for Failure > > case. > > Actually, I followed what is already there for other options. Please see cmd_buildid_cache(), if we failed to purge one buildid-cache, it is warned with pr_warning. if (purge_name_list_str) { list = strlist__new(purge_name_list_str, NULL); if (list) { strlist__for_each_entry(pos, list) if (build_id_cache__purge_path(pos->s, nsi)) { if (errno == ENOENT) { pr_debug("%s wasn't in the cache\n", pos->s); continue; } pr_warning("Couldn't remove %s: %s\n", pos->s, str_error_r(errno, sbuf, sizeof(sbuf))); } strlist__delete(list); } } Thank you, -- Masami Hiramatsu <[email protected]>
