On Wed, May 9, 2018 at 12:31 AM 宋金时 <songjin...@xiaomi.com> wrote:
> In case of the BINDER_WORK_RETURN_ERROR the cmd is no assignment, > so it's value will be old value or dirty value, before modifying > e->cmd, assign the value of the e->cmd to cmd to ensure the correct > print of binder_stat_br. That's not the problem... the problem is that e->cmd is unconditionally set to BR_OK prior to the call to binder_stat_br(proc, thread, e->cmd) so the reported cmd is always BR_OK. > Signed-off-by: songjinshi <songjin...@xiaomi.com> > --- > diff --git a/drivers/android/binder.c b/drivers/android/binder.c > index 4ffc84d..acd7d44a 100644 > --- a/drivers/android/binder.c > +++ b/drivers/android/binder.c > @@ -4086,6 +4086,7 @@ > struct binder_error *e = container_of( > w, struct binder_error, work); > + cmd = e->cmd; > WARN_ON(e->cmd == BR_OK); > binder_inner_proc_unlock(proc); > if (put_user(e->cmd, (uint32_t __user *)ptr)) Don't you also need to use cmd in the call to binder_state_br() below? - binder_stat_br(proc, thread, e->cmd); + binder_stat_br(proc, thread, cmd); -Todd
