Hi Patrick, On 11 May 2018 at 15:15, Patrick Bellasi <[email protected]> wrote: > When a task is enqueue the estimated utilization of a CPU is updated > to better support the selection of the required frequency. > However, schedutil is (implicitly) updated by update_load_avg() which > always happens before util_est_{en,de}queue(), thus potentially > introducing a latency between estimated utilization updates and > frequency selections. > > Let's update util_est at the beginning of enqueue_task_fair(), > which will ensure that all schedutil updates will see the most > updated estimated utilization value for a CPU. > > Reported-by: Vincent Guittot <[email protected]> > Signed-off-by: Patrick Bellasi <[email protected]> > Acked-by: Viresh Kumar <[email protected]> > Cc: Ingo Molnar <[email protected]> > Cc: Peter Zijlstra <[email protected]> > Cc: Vincent Guittot <[email protected]> > Cc: [email protected] > Cc: [email protected] > Fixes: 7f65ea42eb00 ("sched/fair: Add util_est on top of PELT")
Acked-by: Vincent Guittot <[email protected]> > > --- > > Changes in v2: > - improve comment in enqueue_task_fair() (Peter) > - add "Fixes" tag > - add "Acked-by" Viresh tag > ---
