On Wed, May 16, 2018 at 10:07:50AM +0900, Masahiro Yamada wrote: > Hi Andrew, > > 2018-05-16 7:59 GMT+09:00 Andrew Morton <a...@linux-foundation.org>: > > On Tue, 15 May 2018 11:22:05 +0900 Masahiro Yamada > > <yamada.masah...@socionext.com> wrote: > > > >> This header file is not exported. It is safe to reference types > >> without double-underscore prefix. > >> > > > > It may be safe to do this, but why is it desirable? > > > It is shorter. That's all. > If it is a noise commit, please feel free to drop it. > > > BTW, a large amount of kernel-space code > uses underscore-prefixed types.
Sometimes it can/should do that. > I wonder if we could check it by checkpatch.pl or something... You do understand the difference between the two types and why/when they are needed, right? I don't think checkpatch.pl can determine if data is coming from userspace or not very easily to make this a simple perl script check :( thanks, greg k-h
